Having a problem with combos

[Ssiimmee]

So basically, when i try to make a "button mashing combo" (press b and then b to chain to next move) it fails
It becomes a movecontact combo like press b once and he does combostart. And if he hits he just keeps going to comboend. I want him to NOT go to comboend if i dont press B when he hits.
And here's the code:

[State -1, Combostart]
type = ChangeState
value = 6000
triggerall = command = "b"
triggerall = command != "holddown"
trigger1 = ctrl
trigger1 = statetype = S
trigger2 = stateno = 6100
trigger2 = animelemtime(7) > 0


;---------------------------------------------------------------------------
[State -1, Comboend]
type = ChangeState
value = 6100
trigger1 = command = "b"
trigger1 = command != "holddown"
trigger1 = ctrl
trigger1 = statetype = S

Should i also include hitdef codes?
I wont now scince i dont think it is needed, tell me if i should.
(i just followed Cyanide's buttom mashing tut)

[Cyanide]

I think you're buffering the B command so it's still active when animelemtime(7) kicks in.

[Ssiimmee]

I think you're buffering the B command so it's still active when animelemtime(7) kicks in.

As i'm still a noob at fighter factory, the question is unavoidable (dun dun dun)
How do i fix this?   

[Cybaster]

It has nothing to do about fighter factory. It has to do with writing Mugen code.

Look at trigger2 of your combo start.
You're telling the character to go to combo start if you're in combo end and the time of the 7th element of the animation is > 0.
What does this even mean ?

You're supposed to trigger combo end in combo end itself.
Remove this trigger2 from combo start and place the good trigger in combo end :
It should be performed when :
- command="b"
- command != "holddown"
- stateno = 6000 (which is combo start's stateno, in which you have to be to trigger combo end)
- animelemtime(7)>0 (or at least I guess that's what you wanted to do in the 1st place).

No real need for statetype=S, and i doubt you have ctrl of the character at this point of the move.

[Hero]

Actually, you need a variable to buffer the value of the command, for example, var(4) is modified from Animelemtime(1) > 0 to animelemtime(7) < 0, so, you can "buffer" the button while in those frames, and set the var to 1 if button is mashed. When you changestate, check for var(4) instead of command trigger.

[Cybaster]

You're being too technical here. Basics first.

[Hero]

It`s the best method IMO, well, I have time, I´ll do it more simple:

Pick a unused var. I´ll call this var, the var(4). Choose anyone you want, make sure isn´t used yet.

Then, set the var at the start of the move, using this:

Code Select Expand


[State lala, Varset]
type = Varset
trigger1 = !Time ; this means at start of the state.
var(4) = 0 ; set to 0 EVERY TIME he get the attack state

Then, when you can buffer the command, set the var to 1

Code Select Expand


[State lala, Varset]
type = Varset
trigger1 = Command = "b" ;or anyone youy want
trigger1 = AnimElemTime(1) > 0 && AnimElemTime(7) < 0; from the start until the last frame of the 6 sprite.
trigger1 = !var(4) ; This means you can set it to 1 ONE TIME, when it´s aleready 0. Use this to keep the command in buffer
var(4) = 1 ;set to 1

Then, in the changestate, use the var trigger instead of command.

Code Select Expand


[code]
[State lala, ChangeState]
type =ChangeState
trigger1 = AnimElem = 7 && var(4) ; In the 7º "sprite" and if you mashed the command before.
state = state that you want to combo into

and so


EDIT: I also seek your code and you need ctrl to perform, and I think you need movecontact too.

[Cyanide]

He's doing a button mash combo, this means it runs through it AS you tap the key, not when you hit.

Most likely he has

buffer.time set to a high value up the top so B is still true throughout the attack. Unless he has another changestate that's the problem.